Skip to content

Remote fallback is implemented on remote unavailability#3562

Merged
Kerollmops merged 1 commit intomainfrom
sharding-remote-fallback
Apr 25, 2026
Merged

Remote fallback is implemented on remote unavailability#3562
Kerollmops merged 1 commit intomainfrom
sharding-remote-fallback

Conversation

@Kerollmops
Copy link
Copy Markdown
Member

@Kerollmops Kerollmops commented Apr 24, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Documentation
    • Updated remote availability documentation to reflect automatic remote fallback behavior. When a chosen remote is unreachable, the system now queries an alternate available remote for shard content. Clarified that results may only be missing when no remote exists for that shard.

@Kerollmops Kerollmops requested a review from qdequele April 24, 2026 09:11
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Documentation updated to clarify remote availability behavior during shard replication. The text now describes automatic fallback to alternate remotes when the chosen remote is unreachable, while still noting that results can be missing if no remote exists for a shard.

Changes

Cohort / File(s) Summary
Documentation
resources/self_hosting/sharding/configure_replication.mdx		 Updated remote availability section to reflect automatic remote fallback behavior instead of guaranteed missing results, with clarification on best-effort guarantees when no remote exists for a shard.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A single line changed, a story retold,
Remote fallback flows, more clever than cold,
When one path fails, another shall guide,
Best-effort logistics, with nowhere to hide! 📚✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: documenting the implementation of remote fallback behavior when a remote becomes unavailable, which is the core update reflected in the documentation file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sharding-remote-fallback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kerollmops Kerollmops enabled auto-merge April 24, 2026 09:12
coderabbitai[bot]
coderabbitai Bot reviewed Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@resources/self_hosting/sharding/configure_replication.mdx`:
- Line 92: Rewrite the sentence to remove the contradiction by explicitly
stating that an unreachable remote is skipped and that another remote for the
same shard will be used as a fallback; split into two short sentences (e.g., "If
the remote assigned to a shard is unreachable, that remote is skipped.
Meilisearch will try another remote for the same shard to retrieve its content;
if none are available, the shard's results will be missing.") — update the
sentence in the configure_replication.mdx paragraph that begins "Meilisearch
supports automatic remote fallback" accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4ee5f275-b428-46cd-ba88-a4672d47e663

📥 Commits

Reviewing files that changed from the base of the PR and between f7994f4 and c2e54b9.

📒 Files selected for processing (1)
  • resources/self_hosting/sharding/configure_replication.mdx

Comment thread resources/self_hosting/sharding/configure_replication.mdx
@mintlify
Copy link
Copy Markdown

mintlify Bot commented Apr 24, 2026 •
edited
Loading

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
meilisearch-documentation 🟢 Ready View Preview Apr 24, 2026, 9:15 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@Kerollmops Kerollmops added this pull request to the merge queue Apr 25, 2026
Merged via the queue into main with commit cf8ceb9 Apr 25, 2026
3 of 4 checks passed
@Kerollmops Kerollmops deleted the sharding-remote-fallback branch April 25, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@qdequele qdequele qdequele approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kerollmops @qdequele